GDD: trigger chain selection when caught-up #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Genesis is disable statically, we never even schedule any LoE reprocessing, so this doesn't change anything in this situation. When Genesis is disabled and we are caught-up, then there are concrete scenarios where we want to reprocess LoE blocks, see the preceding two commits.
amesgen
requested review from
jasagredo,
fraser-iohk,
dnadales,
geo2a and
jorisdral
as code owners
nfrisby
approved these changes
May 16, 2025
There was a problem hiding this comment.
[nix-shell:~/cardano-haskell]$ (cd ouroboros-consensus; git lg -5)
429d26d89 - (HEAD -> amesgen/genesis-caughtup-final-chainsel) Revert "GDD: trigger chain selection when caught-up" (13 hours ago) <Nicolas Frisby>
aa3350358 - Revert "ChainSel: reprocess LoE-delayed blocks even when LoE is disabled" (13 hours ago) <Nicolas Frisby>
5c2bd47cf - (origin/amesgen/genesis-caughtup-final-chainsel) ChainSel: reprocess LoE-delayed blocks even when LoE is disabled (4 days ago) <Alexander Esgen>
b4e886f50 - GDD: trigger chain selection when caught-up (4 days ago) <Alexander Esgen>
f2ba4bcd1 - Regression test for #1503 (4 days ago) <Alexander Esgen>
[nix-shell:~/cardano-haskell]$ x=ouroboros-consensus-diffusion:test:consensus-test; cabal build $x && cabal run $x -- -p'/Select best chain when CaughtUp/'
Up to date
ouroboros-consensus
Genesis tests
LoE
Select best chain when CaughtUp: FAIL
*** Failed! Falsified (after 1 test):
Schedule control: ControlDefault
No thread delayed
Selection tip is not C
At (Block {blockPointSlot = SlotNo 1, blockPointHash = (testHashFromList [2])}) /= At (Block {blockPointSlot = SlotNo 2, blockPointHash = (testHashFromList [1,0])})
Use --quickcheck-replay="(SMGen 9786910051759926736 5637335760815486691,0)" to reproduce.
1 out of 1 tests failed (0.01s)
[nix-shell:~/cardano-haskell]$ (cd ouroboros-consensus; git reset --hard HEAD^^)
HEAD is now at 5c2bd47cf ChainSel: reprocess LoE-delayed blocks even when LoE is disabled
[nix-shell:~/cardano-haskell]$ x=ouroboros-consensus-diffusion:test:consensus-test; cabal build $x && cabal run $x -- -p'/Select best chain when CaughtUp/'
*snip: recompilation*
ouroboros-consensus
Genesis tests
LoE
Select best chain when CaughtUp: OK (1.38s)
+++ OK, passed 1000 tests.
Branching factor (78000 in total):
51.282% 0
28.205% 1
11.538% 3
7.692% 2
1.282% 10-19
Modified schedules explored (1000 in total):
100.0% 70-79
Race reversals per schedule (78000 in total):
56.410% 2
39.744% 1
2.564% 3
1.282% 0
All 1 tests passed (1.39s)
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1503
The first commit adds a regression test, which is then fixed by the second and third commit in this PR. Reverting either commit makes the regression test fail as expected.